Skip to content

Conversation

@GrahamCampbell
Copy link
Collaborator

This is a really nice feature. The collection class is one of the best things in Laravel! It is also a boon for consistency.

This one does not touch the getModels method, or anything that has to do with relations or eager loading. In fact, it doesn't touch anything Eloquent related, so it's much safer.

We also now have the integration tests, which really helps.

Replaces #7213.

@taylorotwell
Copy link
Member

Conflicts?

@JosephSilber JosephSilber force-pushed the query-builder-collection branch from 1006e0a to 4c8c94b Compare February 23, 2015 19:14
@JosephSilber
Copy link
Contributor

@taylorotwell rebased.

@GrahamCampbell
Copy link
Collaborator Author

Looks pretty nice. 👍

@JosephSilber
Copy link
Contributor

@GrahamCampbell out of curiosity: how did you originally move this PR that was targeted at 5.0 to master?

@RomainLanz
Copy link

He just create a new PR with your branch across all fork and target master.

@GrahamCampbell
Copy link
Collaborator Author

Yeh, anyone can create a pull to and from any repo on github. They don't need any special permissions. :)

@taylorotwell
Copy link
Member

Want to hold off on this as I want to minimize breaking changes in 5.1 and it is rather trivial to just collect your DB results if you want a collection of them.

@GrahamCampbell
Copy link
Collaborator Author

:(

@JosephSilber JosephSilber deleted the query-builder-collection branch May 19, 2015 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants