Added paginate function back to the BelongsToMany class to fix issues with pivots. #7476
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The BelongsToMany class doesn't have its paginate function like it did in L4. This is causing issues where the pivots are not taken care of correctly. The HasManyThrough class still has its paginate function, so I'm guessing it is supposed to be there.
A query like this below is selecting the messages by the id of pivot table instead of the conversation id because the pivot alias is not being set.
Using get() instead of paginate works correctly and eager loads the correct message ids
The correct ids are ('1', '2', '3', '4', '5', '6', '7', '8')
When using paginate()
Uses the user_conversation pivot table ids of ('1', '3', '5', '7', '9', '11', '13', '15')
Adding paginate back to the BelongsToMany class correctly alias the pivots and gives the correct results.