Remove Authenticates from AuthenticatesAndRegistersUsers to its own trait #7567
Conversation
…alidator and create
|
This is not a breaking change, so should probably go to 5.0 |
|
I've made this pull request on the master mostly because of those two abstract methods. I have an older project starter and my AuthController didn't have the validator & create methods and that broke things. My IDE could not tell me that I need to implement thoes two methods, I had to dig into the code to see which changes broke my code and thoes changes are not in 5.0 branch. |
|
Nice, though I know Graham will give you a list of coding style errors to fix. |
There was a problem hiding this comment.
No extra new line.
There was a problem hiding this comment.
OK, got it. If you find something else, let me know.
There was a problem hiding this comment.
There's multiple occurrences in this pull request.
|
No plans to implement this right now. |
6 participants
I had the need to implement the AuthenticatesAndRegistersUsers trait with just the authentication part so I thougth that these two should be splited. Authentication doesn't really need registration, but registration should imply the need of authentication.
I've also added the need of implementing the two methods (validator and create) if someone use the AuthenticatesAndRegistersUsers trait, since these are used but not defined as needed.