-
Notifications
You must be signed in to change notification settings - Fork 11.6k
[5.1] Added cached compile and service path methods to the Application interface #9135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…pplication interface
[5.1] Added cached compile and service path methods to the Application interface
|
@taylorotwell @GrahamCampbell @proshanto, I think its not completely resolved. I have the same problem that @martinssipenko have. In this issue: laravel/lumen-framework#137 |
|
Yes, we know... |
|
Lumen 5.1 is NOT meant to be used yet. |
|
Only testing... no production! |
|
Same goes there really. |
|
@taylorotwell @GrahamCampbell Sorry... try it later on! |
|
@jonathanpmartins Application contract is not perfect. There are lots of things to be done. Laravel right now is tightly coupled to the foundation implementation. |
|
Not really. All we need to do is change our contracts so that they extend array access. |
|
Nah, there are still quite a lot other places where methods are used that aren't in the contract. Take a look at some of the bootstrapper classes, for example. |
|
@franzliedke Yeah from some artisan commands too. |
|
I'm sure Taylor would accept PRs to 5.2 to improve this provided they're not adding a massive load of methods to the contracts. NB getter/setter stuff won't get accepted to contracts. |
|
👍 |
Fixes #8229 and requested by @GrahamCampbell