Skip to content

Conversation

@proshanto
Copy link
Contributor

Fixes #8229 and requested by @GrahamCampbell

taylorotwell added a commit that referenced this pull request Jun 8, 2015
[5.1] Added cached compile and service path methods to the Application interface
@taylorotwell taylorotwell merged commit 15d7846 into laravel:5.1 Jun 8, 2015
@jonathanpmartins
Copy link
Contributor

@taylorotwell @GrahamCampbell @proshanto, I think its not completely resolved. I have the same problem that @martinssipenko have. In this issue: laravel/lumen-framework#137

@GrahamCampbell
Copy link
Collaborator

Yes, we know...

@GrahamCampbell
Copy link
Collaborator

Lumen 5.1 is NOT meant to be used yet.

@jonathanpmartins
Copy link
Contributor

Only testing... no production!

@GrahamCampbell
Copy link
Collaborator

Same goes there really.

@jonathanpmartins
Copy link
Contributor

@taylorotwell @GrahamCampbell Sorry... try it later on!

@proshanto
Copy link
Contributor Author

@jonathanpmartins Application contract is not perfect. There are lots of things to be done. Laravel right now is tightly coupled to the foundation implementation.

@GrahamCampbell
Copy link
Collaborator

Not really. All we need to do is change our contracts so that they extend array access.

@franzliedke
Copy link
Contributor

Nah, there are still quite a lot other places where methods are used that aren't in the contract. Take a look at some of the bootstrapper classes, for example.

@proshanto
Copy link
Contributor Author

@franzliedke Yeah from some artisan commands too.

@GrahamCampbell
Copy link
Collaborator

I'm sure Taylor would accept PRs to 5.2 to improve this provided they're not adding a massive load of methods to the contracts. NB getter/setter stuff won't get accepted to contracts.

@proshanto
Copy link
Contributor Author

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants