Using the assertSame and fix assertSame parameters #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

driesvints merged 1 commit into laravel:master from peter279k:test_enhancement

Sep 3, 2020

Contributor

peter279k commented Sep 3, 2020

Changed log

Using the assertSame to replace assertEquals and it can make assertion equals strict.
According to the official PHPUnit doc, the assertSame parameters are assertSame(mixed $expected, mixed $actual[, string $message = '']).
And parameters should be switched.


          Using the assertSame and fix assertSame parameters

cebb89f

driesvints merged commit 6dfb730 into laravel:master

Member

driesvints commented Sep 3, 2020

Thanks

peter279k deleted the test_enhancement branch

September 3, 2020 07:54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet