Skip to content

Fix option calls #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 5, 2021
Merged

Fix option calls #187

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
96d8930
Fix gathering options
driesvints Mar 4, 2021
355024b
Fix option calls
driesvints Mar 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/NewCommand.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ protected function configure()
->addArgument('name', InputArgument::REQUIRED)
->addOption('dev', null, InputOption::VALUE_NONE, 'Installs the latest "development" release')
->addOption('git', null, InputOption::VALUE_NONE, 'Initialize a Git repository')
->addOption('github', null, InputOption::VALUE_OPTIONAL, 'Create a new repository on GitHub')
->addOption('github', null, InputOption::VALUE_OPTIONAL, 'Create a new repository on GitHub', false)
->addOption('jet', null, InputOption::VALUE_NONE, 'Installs the Laravel Jetstream scaffolding')
->addOption('stack', null, InputOption::VALUE_OPTIONAL, 'The Jetstream stack that should be installed')
->addOption('teams', null, InputOption::VALUE_NONE, 'Indicates whether Jetstream should be scaffolded with team support')
Expand Down Expand Up @@ -123,15 +123,15 @@ protected function execute(InputInterface $input, OutputInterface $output)
);
}

if ($input->hasOption('git') || $input->hasOption('github')) {
if ($input->getOption('git') || $input->getOption('github') !== false) {
$this->createRepository($directory, $input, $output);
}

if ($installJetstream) {
$this->installJetstream($directory, $stack, $teams, $input, $output);
}

if ($input->hasOption('github')) {
if ($input->getOption('github') !== false) {
$this->pushToGitHub($name, $directory, $input, $output);
}

Expand Down Expand Up @@ -226,7 +226,7 @@ protected function createRepository(string $directory, InputInterface $input, Ou
*/
protected function commitChanges(string $message, string $directory, InputInterface $input, OutputInterface $output)
{
if (! $input->hasOption('git') && ! $input->hasOption('github')) {
if (! $input->getOption('git') && $input->getOption('github') === false) {
return;
}

Expand Down