Simplify push to GitHub #238
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fgaroby
reviewed
Nov 3, 2022
|
|
||
| $name = $input->getOption('organization') ? $input->getOption('organization')."/$name" : $name; | ||
| $flags = $input->getOption('github') ?: '--private'; | ||
| $branch = $input->getOption('branch') ?: $this->defaultBranch(); |
There was a problem hiding this comment.
Isn't this variable $branch (or even the whole line) useless now?
There was a problem hiding this comment.
You're right. But it's not necessary here anymore since the --push flag will push the new branch to the repo with the same name. This was more a fallback for how the old way worked.
There was a problem hiding this comment.
I removed this line: ea0b3b6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub has added a new
--pushflag which simplifies the process of pushing the HEAD branch to the newly created repo.See cli/cli#3209 (comment)