Show the directory name at the end of the installer #270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driesvints
approved these changes
Aug 8, 2023
nunomaduro
requested changes
Aug 8, 2023
src/NewCommand.php
Outdated
| } | ||
|
|
||
| $output->writeln(' <bg=blue;fg=white> INFO </> Application ready! <options=bold>Build something amazing.</>'.PHP_EOL); | ||
| $output->writeln(" <bg=blue;fg=white> INFO </> Application ready in <options=bold>[{$name}]</>.".PHP_EOL); |
Member
There was a problem hiding this comment.
Still feel that the Build something amazing! could be the same line. Something like this:
[INFO] Application ready in [./my-application]. Build something amazing!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the final output of the installer to include the chosen directory name:
This might not be an issue for most, but I often forget the directory name I chose, especially if I switched away while the installer runs.
The Vue installer does something similar (including the name twice), but I opted not to provide the
cdinstruction because it looked a little weird on its own (we don't need to tell them tocomposer install) and developers may want to open the directory in their editor instead of "cd-ing".I also wondered whether it could be worth adding some "Next Steps" including links to the docs on running development servers and using starter kits. Thoughts?