Skip to content

Conversation

@crynobone
Copy link
Member

@crynobone crynobone commented Aug 18, 2023

  • Allow selecting sqlite, mysql or pgsql driver using Laravel Prompts
  • Default to mysql if accessed via --no-interaction.
  • Update DB_CONNECTION to the correct database driver. (SQLite database doesn't update .env.example)
  • Comment other DB_* variables when using sqlite.
  • Update DB_PORT value based on selected database driver.

crynobone and others added 6 commits August 18, 2023 23:01
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
@crynobone crynobone marked this pull request as ready for review August 19, 2023 03:08
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
@taylorotwell
Copy link
Member

Wouldn't you typically change the port on Postgres?

@taylorotwell taylorotwell marked this pull request as draft August 21, 2023 21:10
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
@crynobone
Copy link
Member Author

Wouldn't you typically change the port on Postgres?

Added script to change default port, and allow selecting MSSQL

@crynobone crynobone marked this pull request as ready for review August 22, 2023 12:53
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
@driesvints driesvints deleted the select-db branch August 25, 2023 14:29
@taylorotwell taylorotwell restored the select-db branch August 25, 2023 14:31
@taylorotwell taylorotwell reopened this Aug 25, 2023
@taylorotwell taylorotwell merged commit d340db3 into master Aug 25, 2023
@taylorotwell taylorotwell deleted the select-db branch August 25, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants