Skip to content

Conversation

@mbabker
Copy link
Contributor

@mbabker mbabker commented Dec 11, 2017

Unless I'm missing something obvious there should be no need to run post-autoload-dump a second time for dev.

@taylorotwell
Copy link
Member

@themsaid any idea why this might have been here or was it a mistake?

@themsaid
Copy link
Member

I think the entire block should be removed:

if ($input->getOption('dev')) {
    unset($commands[2]);

    $commands[] = $composer.' run-script post-autoload-dump';
}

All these commands has to run in master and dev:

$composer.' install --no-scripts',
$composer.' run-script post-root-package-install',
$composer.' run-script post-create-project-cmd',
$composer.' run-script post-autoload-dump',

@mbabker
Copy link
Contributor Author

mbabker commented Dec 11, 2017

It originally came from #64 so based on the comments there the post-create-project-cmd script wouldn't be needed at all now.

@themsaid
Copy link
Member

@mbabker but that script creates the app key.

@mbabker
Copy link
Contributor Author

mbabker commented Dec 11, 2017

Ah, ya, just had to look to double check. If block is gone in full now.

@taylorotwell taylorotwell merged commit efe0c9d into laravel:master Dec 12, 2017
@mbabker mbabker deleted the patch-1 branch December 12, 2017 14:54
Copy link

@amirringo amirringo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants