Update .gitignore #82
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
do not commit the composer lock file. when forking and updating the repo, users run `composer update` to get the latest dependencies. this creates a `composer.lock` file that we don't want committed back to the package repo. similar to other Laravel packages that don't commit the lock file.
Member
|
Thanks but we'll have to remove the composer.lock file first. |
Member
|
Deleted it. Thanks! |
Contributor
Author
|
thanks for catching that! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
do not commit the composer lock file.
when forking and updating the repo, users run
composer updateto get the latest dependencies. this creates acomposer.lockfile that we don't want committed back to the package repo.similar to other Laravel packages that don't commit the lock file.
https://github.com/laravel/horizon/blob/2.0/.gitignore
https://github.com/laravel/tinker/blob/master/.gitignore