fix: allow multi-segment issuer paths #105
Merged
+95
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds support for multi-segment issuer paths in the OAuth well-known endpoints registered by
Registrar::oauthRoutes().Why is this needed?
According to the OAuth 2.1 / OpenID Connect Discovery specification, the
issuerURI may contain path segments (e.g.https://api.example.com/mcp/weather).Previously, the route definition only matched a single path segment, so requests to nested issuers like
/mcp/weatherwere not discoverable.This patch updates both the
/.well-known/oauth-protected-resource/{path?}and/.well-known/oauth-authorization-server/{path?}routes to allow multi-segment paths.How does this benefit users?
https://example.com/mcp/weather).What changed?
.well-knownroutes to use.where('path', '.*'), allowing multiple path segments.Breaking changes?
None.
Tests
Added new tests in
tests/Unit/Server/RegistrarTest.php:it('handles oauth discovery with multi-segment paths')it('handles oauth discovery with single segment paths')it('handles oauth discovery with no path')These verify correct JSON responses and ensure backward compatibility across all cases.
References
/mcp/weatheras a nested path.