feat: tested Sanctum support #33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need this for MCP routes so the 'authenticate' middleware returns a JSON 401, even if the JSON isn't the first preference in the 'Accept' header. This happens in VS Code for example where its Accept header asks for text-event-stream first, then application/json, but it still expects a JSON 401 response or it breaks.
MCP specification expects 202 status code to empty responses from pings/notifications
ashleyhindle
commented
Sep 8, 2025
ashleyhindle
changed the title
# Conflicts: # README.md # src/Console/Commands/InspectorCommand.php # src/Server/Registrar.php # src/Server/Transport/HttpTransport.php
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What & Why
ReorderJsonAcceptMiddlewareWe need this for MCP routes so the 'authenticate' middleware returns a JSON 401, even if the JSON isn't the first preference in the 'Accept' header.
This happens in VS Code for example where its Accept header asks for text-event-stream first, then application/json, but it still expects a JSON 401 response or it breaks.
AddWwwAuthenticateHeaderMiddlewareWe need this to signal to the MCP client where to go to be able to authenticate the user. This is an OAuth requirement, but we return it for Sanctum also with an error message to aid debugging.
How I tested