Global search input is not shown

[WillyReyno]

• Laravel Version: 8.83.8
• Nova Version: 4.2.2
• PHP Version: 8.0
• Database Driver & Version: MySQL 8.0

Description:

The global search input is not visible anymore since upgrading from 3 to 4.

I first created a discussion #4021 and decided to open an issue since I wasn't the only one noticing this.

Detailed steps to reproduce the issue on a fresh Nova installation:

• Open Nova
• Notice the global search input does not appear in the navbar

Feel free to tell me if there's any relevant info I can give to help you debug it.

[crynobone]

Unable to reproduce the issue, please provide full reproducing repository.

[gmoigneu]

static::globallySearchableResources(app(NovaRequest::class)) returns null in my instance. Even when forcing the flag on the Nova model.

authorizedResources(Request $request) is called two times. Unfortunately the Search uses the result from the first iteration without the Models.

^ Laravel\Nova\ResourceCollection {[#1853 ▼]()
  #items: array:1 [[▼]()
    0 => "Laravel\Nova\Actions\ActionResource"
  ]
  #escapeWhenCastingToString: false
}
^ Laravel\Nova\ResourceCollection {[#522 ▼]()
  #items: array:12 [[▼]()
    0 => "Laravel\Nova\Actions\ActionResource"
    1 => "App\Nova\Change"
    2 => "App\Nova\Event"
    3 => "App\Nova\Lead"
    4 => "App\Nova\Note"
    5 => "App\Nova\Opportunity"
    6 => "App\Nova\Product"
    7 => "App\Nova\Project"
    8 => "App\Nova\Recommendation"
    9 => "App\Nova\Sizing"
    10 => "App\Nova\Tracking"
    11 => "App\Nova\User"
  ]
  #escapeWhenCastingToString: false
}

[crynobone]

Are you guys somehow calling Nova::provideToScript() outside of Nova::serving()?

[WillyReyno]

I use Nova::provideToScript() twice inside Nova::serving() :

1. Inside a custom tool :

Nova::serving(function (ServingNova $event) {
            $service = new Service();
            $service->init();
            Nova::provideToScript([
                'developerToken' => $service->api()->getDeveloperToken(),
            ]);
        });

2. Inside a custom Card:

Nova::serving(function (ServingNova $event) {
            Nova::provideToScript([
                'events' => Cache::get('planning'),
            ]);

            Nova::script('planning-card', __DIR__.'/../dist/js/card.js');
            Nova::style('planning-card', __DIR__.'/../dist/css/card.css');
        });

But I confirm that commenting both provideToScript makes the global search appear again...

[wdelfuego]

I'm also setting up a new custom tool locally and only call provideToScript once, within the Nova::serving call in the boot method of my ToolServiceProvider. Commenting out the provideToScript call makes the global search bar appear.

Calling provideToScript with an empty array makes the global search bar disappear as well.

[crynobone]

This doesn't happened on Nova 4 fresh install. I feel we still missing some important information here

[wdelfuego]

Has this issue been fixed or was it closed because of lack of reproducibility?

[wdelfuego]

Looking at the releases page; looks like it’s fixed, awesome!

@davidhemphill is it really too much to ask to respond to simple questions of us paying users? You could have been the bringer of good news just saying “fixed” and we’d all be happy. This silence treatment we get really baffles me.

[crynobone]

@wdelfuego It's 5.25am where I'm at right now, please be reasonable with response time expectation.

Issue with bug label and assigned will (and can only) be automatically closed once the relevant bugfix PR has been merged. We don't wait for the patch release to close tickets.

[wdelfuego]

This has nothing to do with response time expectation, this has to do with communication plain and simple.

Silently closing an issue in which the last update was “can’t reproduce, need more information” is worrying. Other bug reports have been closed without further notice or explanation before and specific requests for information directed at @davidhemphill have been ignored consistently and indefinitely. My email to the support team from almost a week ago has gone unanswered too.

Just adding a comment “fixed” would tell us why this issue has been closed and that we don’t have to investigate further.

This is not about response time, this is about quality of communication.