Call to a member function status() on bool in EnsureRequestsDontExceedMaxExecutionTime

[ibrunotome]

• Octane Version: v1.3.1
• Laravel Version: v9.32.0
• PHP Version: 8.1.1
• Server & Version: OpenSwoole 4.11.1
• Database Driver & Version: postgres 14

Description:

this line https://github.com/laravel/octane/blob/1.x/src/Swoole/Actions/EnsureRequestsDontExceedMaxExecutionTime.php#L33

is returning a bool instead of a http response

Steps To Reproduce:

Make a request longer than config max_execution_time

[driesvints]

Can you send in a PR?

[ibrunotome]

Can you send in a PR?

Sure, What behavior do you want that I implement when $response = Response::create($this->server, $row['fd']); returns a bool?

[driesvints]

@nunomaduro do you know?

[ibrunotome]

This is the exact same issue #545 opened 3 months ago and closed because "it is a support request" 🤔

But I'm happy that it's fixed now.

[driesvints]

It was not clear to me that this was a bug at that time. Your report here was more insightful.