[1.x] Made Roadrunner log level configurable #601
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driesvints
changed the title
driesvints
added a commit
that referenced
this pull request
Oct 26, 2022
This reverts commit 8380c13.
driesvints
added a commit
that referenced
this pull request
Oct 26, 2022
|
@driesvints yes, I made a new Octane app locally and tried running with and without the flag. The commit added by @taylorotwell seems to have subtly broken this (seemingly due to operator precedence of concatenation and |
|
Thanks @ejulen. Can you attempt a new PR and explain the breakage from the previous one? |
|
@driesvints will do! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #597.
This PR adds a new flag to
octane:roadrunner;--log-level, which defaults to the previous behaviour of basing log level on what environment Laravel is currently running in, but now allows for a manual override.Example:
php artisan octane:roadrunner --log-level=info