fix: resolve typo resulting in deprecation notice #614
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@owenvoke this PR seems to have broken our builds. Can you send in a fix for that? |
|
@driesvints, are you meaning the tests? They were broken for 4 days before my PR. 🤔 I'm not entirely sure what the issue is, will see if I can take a look. 👍🏻 |
|
Weird as they seem to start breaking with your PR:
|
|
Yeah, the scheduled daily tests were failing. 👀 Will look into it shortly. |
|
@owenvoke I see. Thanks for pointing that out and looking into it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We noticed that on PHP 8.1, we are receiving the following deprecation notice in Sentry.
json_encode(): Passing null to parameter #2 ($flags) of type int is deprecated in /var/www/vendor/laravel/octane/src/Commands/Concerns/InteractsWithIO.php on line 237It looks like this is just a typo, and the verbosity should be passed to
info()not tojson_encode(). 👍🏻