Update test suite to phpunit 9.5 #1004
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update test suite to phpunit 9.5 syntax
Refactored to use polyfill for older PHP versions via
yoast/phpunit-polyfillsNote: this includes 2 important differences from usual phpunit test suites:
PHPUnit\Framework\TestCasewe extendYoast\PHPUnitPolyfills\TestCases\TestCasesetUp()andtearDown()we useset_up()andtear_down()respectivelyComment regarding formatting: I chose to use the FQDN in the
extendssyntax of the class declaration instead of usinguseso that it is more quickly apparent that we're doing something slightly different than usual phpunit syntax, particularly in regards to the set_up() / tear_down() methods that appear immediately following theextendsline.IMO this closes #1002