Isolation compatibility with .valetphprc #1213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Read .valetphprc on isolation command * wip * wip * wip * remove $site->getSiteUrl() dependency to avoid expection * StyleCI patch
NasirNobin
force-pushed
the
isolation-with-valetphprc
branch
from
204a713 to
fa0bd53
Compare
|
Updated to utilize the new |
NasirNobin
commented
Apr 3, 2022
There aren't any yet, but I've been meaning to add some. We don't need to hold up this PR for that but I'll make an issue. |
|
Great work as always @NasirNobin! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two enhancements:
valet isolate(without specifying a PHP version) on a directory where there's a.valetphprcfile is present, Valet would recognize that.valet use(without specifying a PHP version) on an isolated site directory would change global PHP version to that isolated version.Fixes #1209
Tests: I'm not sure how do we test codes from
cli/valet.phpyet. I would be happy to add tests if I can get some guidance.