Update ContaoValetDriver to support current Contao versions
#1532
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
ContaoValetDriverto support current Contao versions (from Contao 4.9)./web/app.phpwas used until to Contao 4.8, which was released in August 2019, later versions useindex.phpinstead ofapp.php.I don't think it makes sense to still support older versions than 4.8, because they all are unsupported since 2019. But if you still want to support them, I can add it again.
Current versions also use the
publicdirectory, butwebis still supported and is probably still in use by a few people.I have also added support for the Contao Manager, which usually resides in
/public/contao-manager.phar.phpand the preview mode, which uses thepreview.phpfile.