Skip to content

Use strict comparisons #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 27, 2016
Merged

Use strict comparisons #74

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cli/Valet/Ngrok.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ public function currentTunnelUrl()
public function findHttpTunnelUrl(array $tunnels)
{
foreach ($tunnels as $tunnel) {
if ($tunnel->proto == 'http') {
if ($tunnel->proto === 'http') {
return $tunnel->public_url;
}
}
Expand Down
2 changes: 1 addition & 1 deletion cli/Valet/Site.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ function __construct(Configuration $config, CommandLine $cli, Filesystem $files)
function host($path)
{
foreach ($this->files->scandir($this->sitesPath()) as $link) {
if ($resolved = realpath($this->sitesPath().'/'.$link) == $path) {
if ($resolved = realpath($this->sitesPath().'/'.$link) === $path) {
return $link;
}
}
Expand Down
2 changes: 1 addition & 1 deletion cli/drivers/ContaoValetDriver.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ public function isStaticFile($sitePath, $siteName, $uri)
*/
public function frontControllerPath($sitePath, $siteName, $uri)
{
if ($uri == '/install.php') {
if ($uri === '/install.php') {
return $sitePath.'/web/install.php';
}

Expand Down
4 changes: 2 additions & 2 deletions cli/includes/compatibility.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
*/
$inTestingEnvironment = strpos($_SERVER['SCRIPT_NAME'], 'phpunit') !== false;

if (PHP_OS != 'Darwin' && ! $inTestingEnvironment) {
if (PHP_OS !== 'Darwin' && ! $inTestingEnvironment) {
echo 'Valet only supports the Mac operating system.'.PHP_EOL;

exit(1);
Expand All @@ -17,7 +17,7 @@
exit(1);
}

if (exec('which brew') != '/usr/local/bin/brew' && ! $inTestingEnvironment) {
if (exec('which brew') !== '/usr/local/bin/brew' && ! $inTestingEnvironment) {
echo 'Valet requires Brew to be installed on your Mac.';

exit(1);
Expand Down
2 changes: 1 addition & 1 deletion cli/includes/helpers.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ function warning($output)
*/
function output($output)
{
if (isset($_ENV['APP_ENV']) && $_ENV['APP_ENV'] == 'testing') {
if (isset($_ENV['APP_ENV']) && $_ENV['APP_ENV'] === 'testing') {
return;
}

Expand Down