Add support to setup Kirby above webroot #740
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please merge this pull request 🙏 A setup like this is advertised in the Kirby documentation: https://getkirby.com/docs/guide/configuration#custom-folder-setup__public-folder-setup |
Contributor
Author
|
I have been using this driver since last year without any issues. It seems other Kirby developers have to use This CI check error doesn't seem to be related to the new driver. Let me know if any change is required on my end to get this merged in. |
Collaborator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kirby 3 now supports keeping site files above webroot. This PR adds support for it in Valet.
This driver has been tested with Kirby 2 and Kirby 3. Both versions are still supported by the same driver.