-
Notifications
You must be signed in to change notification settings - Fork 718
Add 'parked' command to show all sites which have been parked #824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 'parked' command to show all sites which have been parked #824
Conversation
|
If merged we'll need to add a PR to the Laravel valet docs |
|
Nicely done. I'd suggest we mark (I'd get rid of it altogether, except that there's a tiny rare chance that someone's written an extension that would be broken. Then again, it's such a minor change that any extension could be easily and quickly fixed without creating crazy hardship. This isn't in a production environment!) |
|
@drbyte Sounds good, I've marked as @deprecated for now. |
|
@jrbarnard This looks great. Would you mind fixing the merge resolution issue? |
|
@mattstauffer No problem, I've updated my branch now to remove the conflict |
|
Thanks @jrbarnard! |
|
OK, released in 2.5.0. @jrbarnard are you up to do that docs PR? |
|
Yeah no problem, what branch on the laravel docs should I pr into?
…On Fri, 4 Oct 2019, 22:11 Matt Stauffer, ***@***.***> wrote:
OK, released in 2.5.0. @jrbarnard <https://github.com/jrbarnard> are you
up to do that docs PR?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#824?email_source=notifications&email_token=ABTR7XX5WFDG6EGWWCE2APLQM6PPNA5CNFSM4I4VW6Q2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAMYMQI#issuecomment-538543681>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABTR7XQLKBPRVASI5NBVTLLQM6PPNANCNFSM4I4VW6QQ>
.
|
|
Geez, i dunno. 5.8 maybe? |
|
I dunno what Taylor's preference is. Does he prefer 6.0 and then backport manually? Multiple PRs for each? 5.8 and then he'll merge fwd manually? I dunno. This is where Valet's docs really diverge from Laravel's docs altogether, unfortunately. |
|
I'll go for 5.8 and mention it on the PR so can change if needed. Cheers |
Feature to provide functionality requested in #799
Added under a separate command to be used alongside 'links' for only parked paths.
I left Site::getLinks as I wasn't sure if I should just replace it's usage with the newly added Site::getSites, I can do if that would be better.