Add detailed valet uninstall instructions #851
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously `valet uninstall` would just shutdown the `nginx` service. This PR also stops `PHP` and gives a number of instructions on how to do a (nearly) clean uninstall of most Valet dependencies. And also some troubleshooting tips.
mattstauffer
approved these changes
Dec 1, 2019
Collaborator
mattstauffer
left a comment
mattstauffer
left a comment
There was a problem hiding this comment.
Amazing. You are a prince among men.
Contributor
Author
|
@mattstauffer note that these uninstall instructions require #854 to be merged. ... or we can change the wording to reflect an alternate approach to cleaning up old certs. (eg: run |
Collaborator
|
@drbyte 👌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously
valet uninstallwould just shutdown thenginxservice.This PR also stops
PHPand gives a bunch of instructions on how to do a (nearly) clean uninstall of most Valet dependencies.And also some troubleshooting tips.