Use custom dnsmasq.d folder for easier config and support #856
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drbyte
force-pushed
the
dnsmasq-customconfig
branch
3 times, most recently
from
e325b35 to
050c7c7
Compare
… do. This PR changes Valet's default config process to empower this feature, which makes installation less intrusive, and easier to identify and remove valet-specific customizations. This will make for easier troubleshooting ... and easier customizing (such as dropping in a custom logging config, additional TLDs, alternate DNS resolvers, etc) Also removes old dnsmasq configs used by prior Valet versions
drbyte
force-pushed
the
dnsmasq-customconfig
branch
from
050c7c7 to
02ad7f4
Compare
Contributor
Author
|
Updated to include doing a cleanup of the old config file from previous Valet installs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dnsmasq allows use of a common config folder, much like nginx and php do.
This PR changes Valet's default config to empower this feature.
This will make for easier troubleshooting
... and easier customizing (such as dropping in a custom logging config, additional TLDs, alternate DNS resolvers, etc)