-
Notifications
You must be signed in to change notification settings - Fork 718
Move PHP-FPM pool config to separate valet-specific file #858
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@mattstauffer ya, I've been debating how best to handle that. While I'd prefer not to clutter Valet with a bunch of "upgrade" code, it's probably unavoidable. Two options:
|
|
@drbyte I 100% agree with you on all points. I don't want the junk upgrade code but not sure what else to do. I prefer the nuclear option, and I love the idea of renaming it on new ones. |
|
I'll work on an update later this afternoon. |
|
@mattstauffer I'm toying with just renaming the |
|
@drbyte YES. Why not? If someone needs it, they're already in an advanced-enough situation that they can go look it up. |
e2aac3a to
998f7e4
Compare
|
@mattstauffer Update pushed. |
This allows the valet configuration to stand separately from the default PHP config. This benefits troubleshooting, makes customization of FPM workers and other settings easer and allows for easier uninstallation. Also renames any previously-existing `www.conf` pool config so it doesn't conflict with Valet nor run unnecessary additional processes.
998f7e4 to
139a916
Compare
|
Updated to also make sure the |
|
@drbyte <3 |
This allows the valet FPM pool configuration to stand separately from the default config.
This benefits troubleshooting, makes customization of FPM workers and other settings easer
and allows for easier uninstallation.
(Note: existing Valet installs will have had their PHP
/usr/local/etc/php/7.4/php-fpm.d/www.conffiles already altered by Valet. It will be best to restore this file to the default version installed by PHP to prevent duplicate FPM pool instances that conflict with each other.Or, simply delete the
www.conffile.)