Allow Valet to uninstall itself #866
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattstauffer
requested changes
Dec 6, 2019
Collaborator
mattstauffer
left a comment
mattstauffer
left a comment
There was a problem hiding this comment.
Great work as always!
drbyte
force-pushed
the
valet-uninstall
branch
from
f05d92a to
82cf7c9
Compare
`valet uninstall` only displays information about how to manually uninstall and clean up after Valet. This PR adds a `--force` parameter, which will forcefully remove Valet and the Homebrew services it installs, as well as clean up the config files and log files. But for a few post-uninstall composer dependencies, cleanup is very thorough. This brings idempotency to both `valet install` and `valet uninstall --force` (There may still be edge cases where other Homebrew or composer packages might create interference with install/uninstall, but this makes things much easier to self-troubleshoot.)
drbyte
force-pushed
the
valet-uninstall
branch
from
82cf7c9 to
6e01bfb
Compare
Collaborator
|
As always, you are the best. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
valet uninstallonly displays information about how to manually uninstall and clean up after Valet.This PR adds a
--forceparameter, which will forcefully remove Valet and the Homebrew services it installs, as well as clean up the config files and log files.But for a few post-uninstall composer dependencies, cleanup is very thorough.
This brings idempotency to both
valet installandvalet uninstall --force(There may still be edge cases where other Homebrew or composer packages might create interference with install/uninstall, but this makes things much easier to self-troubleshoot.)