Adds a directory-listing setting for dev convenience #888
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattstauffer
requested changes
Jan 2, 2020
After running `valet directory-listing on` if a URI points to a directory that exists, but the requested file cannot be found in that directory, a directory listing will be displayed. A 404 will still happen if the project directory cannot be found. Running `valet directory-listing off` makes a 404 display (without a listing) if the requested file cannot be found. Supercedes and closes laravel#349 and closes laravel#587
Collaborator
|
Gonna save this for the next release so I can do another read-over and test it out. |
Collaborator
|
Merging but pausing on a release for a sec. Want to test it a bit through actual Composer. |
Collaborator
|
Works great so far. Just trying to make sure we're not accidentally opening up the ability for someone to pass some kind of wonky folder in and then get access to your entire personal documents folder or whatever. Obviously this isn't meant to be open to the public but still.. i'd love to get ahead of that if it were possible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After running
valet directory-listing onif a URI points to a directory that exists, but the requested file cannot be found in that directory, a directory listing will be displayed.A 404 will still happen if the project directory cannot be found.
Running
valet directory-listing offmakes a 404 display (without a listing) if the requested file cannot be found.Supersedes and Closes #349 and Closes #587