Skip to content

Conversation

@bramus
Copy link
Contributor

@bramus bramus commented Apr 29, 2020

This is a workaround to fix #904. Root cause is VSCode yielding the wrong output for logname when launched from the Dock / Spotlight / Finder (see microsoft/vscode#96463). This bug in VSCode prevents valet share from working properly, when invoked from VSCode's terminal.

This workaround makes valet share work properly again in that case: when relaunching valet using sudo it will take in the current$USER and pass it in as an environment variable. This (overridden) environment variable is then used when launching ngrok.

@mattstauffer mattstauffer merged commit bdd1d93 into laravel:master Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Valet share does not use the "normal" ngrok config location by default?

2 participants