Set the max length of the subject to 60 (#324)

* Set the max length of the subject to 60 + add tests

* Remove constant for max thread size

* Add maxlength attribute to subject text field

* Remove unused import

Author: bobbybouwmann

app/Http/Requests/ThreadRequest.php

@@ -11,7 +11,7 @@ class ThreadRequest extends Request
     public function rules()
     {
         return [
-            'subject' => 'required|'.DoesNotContainUrlRule::NAME.'|'.SpamRule::NAME,
+            'subject' => 'required|max:60|'.DoesNotContainUrlRule::NAME.'|'.SpamRule::NAME,
             'body' => 'required|'.SpamRule::NAME,
             'tags' => 'array',
             'tags.*' => 'exists:tags,id',

resources/views/forum/threads/_form.blade.php

@@ -1,7 +1,7 @@
 {!! Form::open(['route' => $route, 'method' => $method ?? 'POST']) !!}
     @formGroup('subject')
         {!! Form::label('subject') !!}
-        {!! Form::text('subject', isset($thread) ? $thread->subject() : null, ['class' => 'form-control', 'required']) !!}
+        {!! Form::text('subject', isset($thread) ? $thread->subject() : null, ['class' => 'form-control', 'required', 'maxlength' => '60']) !!}
         @error('subject')
     @endFormGroup
 

tests/Feature/ForumTest.php

@@ -122,4 +122,45 @@ public function users_cannot_delete_a_thread_they_do_not_own()
         $this->delete('/forum/my-first-thread')
             ->assertForbidden();
     }
+
+    /** @test */
+    public function users_cannot_create_a_thread_with_a_subject_that_is_too_long()
+    {
+        $tag = factory(Tag::class)->create(['name' => 'Test Tag']);
+
+        $this->login();
+
+        $this->visit('/forum/create-thread')
+            ->submitForm('Create Thread', [
+                'subject' => 'How to make Eloquent, Doctrine, Entities and Annotations work together in Laravel?',
+                'body' => 'This is a thread with 82 characters in the subject',
+                'tags' => [$tag->id()],
+            ])
+            ->seePageIs('/forum/create-thread')
+            ->see('Something went wrong. Please review the fields below.')
+            ->see('The subject may not be greater than 60 characters.');
+    }
+
+    /** @test */
+    public function users_cannot_edit_a_thread_with_a_subject_that_is_too_long()
+    {
+        $user = $this->createUser();
+        $tag = factory(Tag::class)->create(['name' => 'Test Tag']);
+        factory(Thread::class)->create([
+            'author_id' => $user->id(),
+            'slug' => 'my-first-thread',
+        ]);
+
+        $this->loginAs($user);
+
+        $this->visit('/forum/my-first-thread/edit')
+            ->submitForm('Update Thread', [
+                'subject' => 'How to make Eloquent, Doctrine, Entities and Annotations work together in Laravel?',
+                'body' => 'This is a thread with 82 characters in the subject',
+                'tags' => [$tag->id()],
+            ])
+            ->seePageIs('/forum/my-first-thread/edit')
+            ->see('Something went wrong. Please review the fields below.')
+            ->see('The subject may not be greater than 60 characters.');
+    }
 }