Set the max length of the subject to 60 #324
Conversation
driesvints
left a comment
driesvints
left a comment
There was a problem hiding this comment.
Nice job. Can you also set a maxlength attribute on the input field of the thread subject? Both in the create and update screen.
app/Http/Requests/ThreadRequest.php
Outdated
| { | ||
| return [ | ||
| 'subject' => 'required|'.DoesNotContainUrlRule::NAME.'|'.SpamRule::NAME, | ||
| 'subject' => 'required|max:'.self::SUBJECT_SIZE.'|'.DoesNotContainUrlRule::NAME.'|'.SpamRule::NAME, |
There was a problem hiding this comment.
You can replace the constant with 60 in the rule itself here.
tests/Feature/ForumTest.php
Outdated
|
|
||
| namespace Tests\Feature; | ||
|
|
||
| use App\Http\Requests\ThreadRequest; |
There was a problem hiding this comment.
You can move the constant from the request to the test case. The reason why you should do this is because your test serves as a sort of contract which means you should try to be as explicit as possible for defining values instead of relying on imported constants. Say someone changes the value in the validator for some reason, you're never going to notice because it's inherited in the test. It's important for this test that the value is 60.
There was a problem hiding this comment.
Good point! I will make some changes ;)
|
Thanks Bobby! |
Set the max length of the subject to 60 (laravelio#324)
2 participants
See #282