Add setting to turn off mention notifications

[driesvints]

Add a new settings section for notifications with a setting to globally turn off/on notifications for subscriptions to threads, including mentions.

[sodu-parisev]

Hello, I would like to contribute. I'm willing to take this task. How I do it right way ? After reading the contribution guide felt like I have to talk before doing anything.

[sodu-parisev]

I assume should look like this. Also it means notification_status boolean field will be added to users table. The field will server as toggle.

[driesvints]

So I think we should maybe look into a notifications JSON column that can hold settings for different notification types later on as well. I think we should display it as a list of type of notifications (currently only one) with a checkbox to toggle them on or off (by default on). The notifications settings would only contain a setting of a type of notification is turned off.

[tvbeek]

Maybe it is an idea to directly split the current situation in 2 notification settings?

One for the new reply notification and another for the mentions? (Now a new reply that mentions you result in 2 notifications so I think it can be useful to manage them separately)

[driesvints]

That’s actually a bug and shouldn’t happen. Can you maybe open an issue for that @tvbeek?

[tvbeek]

That’s actually a bug and shouldn’t happen. Can you maybe open an issue for that @tvbeek?

Yes, done in #937

[sodu-parisev]

I guess better to have #937 done first ?

[driesvints]

They're separate things really.

[sodu-parisev]

What I got from the conversation above is:

1. We will have notifications json field on users table
2. The field will store a list of json objects like for example [{"reply":"off"},{"mentions":"off"}]
3. On the settings page will be shown list of notification types with checkboxes to toggle them on/off

am I right ?

[driesvints]

More like:

[{"replies":false},{"mentions":false}]

[sodu-parisev]

okay, got it, will do