Allow multiple spaces between words in subject #322
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driesvints
requested changes
Oct 19, 2017
Member
driesvints
left a comment
driesvints
left a comment
There was a problem hiding this comment.
Thanks for sending this in! Just two small changes needed and I'll merge this.
tests/Feature/ForumTest.php
Outdated
| ->see('Foo Tag') | ||
| ->see('Thread successfully created!'); | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
You can remove this test again. The bug is covered with the smaller test for the validation rule above.
| { | ||
| const STRING_WITH_URL = 'This is a string http://example.com with an url in it.'; | ||
| const STRING_WITHOUT_URL = 'This is a string without an url in it.'; | ||
| const STRING_WITH_A_REGRESSION = 'JSON not possible with MSSQL running on Windows platform?'; |
Member
There was a problem hiding this comment.
Can you remove this constant again? I forgot to remove it in a previous commit :')
Contributor
Author
|
I'll take care of the requested changes shortly. Thanks! |
driesvints
approved these changes
Oct 19, 2017
Member
|
Thanks! Will come online in a bit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #321
Also, if you look closely at #318, the failure was due to two whitespaces after "JSON".
Current
Currently, the way the subject is checked DoesNotContainUrlRule is that the subject is "exploded" into an array, then each element is checked via:
if the loop completes, with each element failing the 'url' check, then the custom rule passes.
Problem
The problem is that if there is more than one space between words in the subject, some elements of the exploded subject will just be an empty string, which in this case passes
['word' => 'url']validation. This in turn makes the custom rule fail.Goal
Honestly, I think you should consider adding some sanitization to your inputs, then we could avoid this fix. So if you don't want to pull this in, and address it closer to the beginning of the request, that's great as well.