-
-
Notifications
You must be signed in to change notification settings - Fork 669
Share articles on Twitter #554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
08e193e to
041ddec
Compare
driesvints
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work here @joedixon. Sorry it took me this long...
database/migrations/2020_07_18_122946_update_users_table_add_twitter_handle_field.php
Outdated
Show resolved
Hide resolved
|
Could also use a rebase btw. |
|
I was thinking it could be cool if we saved the ID of the tweet as well as shared_tweet_id or something so we can link to it in a dashboard from us. Could also do stuff with that later on. |
f8aa257 to
872bcf0
Compare
73eaa20 to
92ce268
Compare
4ea6eab to
124a0da
Compare
9c15f73 to
e8412f1
Compare
@joedixon I don't think that's true? I don't see any changes to the profile page in this PR. Or maybe I'm looking over them.. |
It's in this partial: laravel.io/resources/views/users/_user_info.blade.php Lines 65 to 75 in 5270914
|
|
Ah, I indeed overlooked it. Thanks I'll try to review this and the other pr soon. |
driesvints
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good. Just a couple more things.
...grations/2020_07_16_185353_update_articles_and_users_tables_to_include_share_information.php
Outdated
Show resolved
Hide resolved
driesvints
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay this looks good to me 👍
I'll try to set up the Twitter app soon.
|
You can hang fire on this if you like. Happy to find some time next week to look at storing the tweet ID as I think that's a good idea 👍 |
Waiting for the storing Tweet ID changes.
8a58ee2 to
b34115b
Compare
driesvints
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few small things.

This PR resolves #539
There is a scheduled command which runs every minute, but utilises a
wheremethod to tweet only twice in a 24 hour period.After the tweet is posted, it is flagged in the database so it can't be shared again. Pending articles are posted in chronological order based on the
submitted_attimestamp (oldest first).This PR also allows users to add their Twitter handle to their profile. If provided, it will be used to attribute the content when shared. We full back to the name if not. There is a note of the article creation page to request users add their handle before publishing.
Here is an example tweet:
Before deploying, we'll need to create a Twitter app and add the credentials to the
.env