Skip to content

Conversation

@faissaloux
Copy link
Contributor

resolves #751

Screenshot from 2021-11-22 14-09-33

Copy link
Contributor

@joedixon joedixon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great @faissaloux. Just a couple of suggestions to keep it more in line with the rest of the project.

Could you also perhaps write some istuctions on what is needed from a deployment perspective to get it running? e.g. how do we get the channel id, how do we get the bot token etc.

Thanks for jumping on this so quickly!

@faissaloux faissaloux requested a review from joedixon November 22, 2021 15:41
@faissaloux
Copy link
Contributor Author

Instructions:

  • Talk to @BotFather and generate a Bot API Token.
  • Copy the Bot API Token and paste it in .env file TELEGRAM_BOT_TOKEN.
  • Add the Bot as admin with "Post messages" permission to the channel where you want to receive notifications in.
  • Get channel id:
    • Go to Old telegram web version.
    • Click on the channel.
    • Look the URL param p looks like c1212121212_54651216546
    • Copy the part between c and _ both excluded.
    • Prefix what you have copied with a -100.
    • Channel id looks like -1001212121212
  • Copy the channel id and paste it in .env file TELEGRAM_CHANNEL.

That it! 🚀 🚀

@joedixon
Copy link
Contributor

Thanks @faissaloux I'll try to review this later this evening.

@faissaloux faissaloux requested a review from joedixon November 24, 2021 21:44
@driesvints driesvints changed the title send telegram notification when new article submitted Send telegram notification when new article submitted Nov 25, 2021
@faissaloux faissaloux force-pushed the telegram-notification branch from 37b9e85 to ce37a28 Compare November 28, 2021 14:45
@joedixon
Copy link
Contributor

Thanks for this @faissaloux and sorry it took a while to review.

I ended up refactoring a bit so the message is only sent when the article is submitted for approval.

Thank you for your hard work, this is really great.

@joedixon joedixon requested a review from driesvints November 30, 2021 22:05
Copy link
Member

@driesvints driesvints left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job @joedixon. Just one remark.

@joedixon joedixon merged commit 3ad7daa into laravelio:main Dec 2, 2021
@driesvints
Copy link
Member

Thanks @faissaloux & @joedixon!

@faissaloux faissaloux deleted the telegram-notification branch December 2, 2021 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Notify us on Telegram when new articles are submitted

3 participants