-
-
Notifications
You must be signed in to change notification settings - Fork 669
Send telegram notification when new article submitted #762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
joedixon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great @faissaloux. Just a couple of suggestions to keep it more in line with the rest of the project.
Could you also perhaps write some istuctions on what is needed from a deployment perspective to get it running? e.g. how do we get the channel id, how do we get the bot token etc.
Thanks for jumping on this so quickly!
Instructions:
That it! 🚀 🚀 |
|
Thanks @faissaloux I'll try to review this later this evening. |
37b9e85 to
ce37a28
Compare
|
Thanks for this @faissaloux and sorry it took a while to review. I ended up refactoring a bit so the message is only sent when the article is submitted for approval. Thank you for your hard work, this is really great. |
driesvints
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job @joedixon. Just one remark.
|
Thanks @faissaloux & @joedixon! |
resolves #751