Skip to content

Conversation

@denniseilander
Copy link
Contributor

@denniseilander denniseilander commented Apr 13, 2022

I checked the RSS feed and I noticed that the urls of the articles were not pointing to the actual article.
As you can see in the example below, the URL to the article is passed as an URL query.

This is caused by using the wrong route name. When using the articles.show route, the URL becomes https://laravel.io/articles/an-unopinionated-package-to-make-laravel-apps-tenant-aware which is an actual page.

<entry>
  <title>
    <![CDATA[ An unopinionated package to make Laravel apps tenant aware ]]>
  </title>
  <link rel="alternate" href="https://laravel.io/articles?an-unopinionated-package-to-make-laravel-apps-tenant-aware"/>
  <id>https://laravel.io/3</id>
...
</entry>

In addition, I also saw that non-published articles showed up in the feed, which leads to a 404 page.

@denniseilander denniseilander changed the title Use articles.show route to get correct url Use articles.show route to get correct url and only show published articles Apr 13, 2022
@driesvints driesvints merged commit df55c03 into laravelio:main Apr 14, 2022
@driesvints
Copy link
Member

Thanks @denniseilander!

@denniseilander denniseilander deleted the patch-1 branch April 14, 2022 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants