статьи и комментарии для профиля #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agoalofalife
requested changes
Nov 10, 2023
| public function edit(Post $post): View | ||
| { | ||
| //нужно будет проверять аавтора, если пост существует | ||
| $this->authorize('ownerBool',$post); |
Member
There was a problem hiding this comment.
тут по PSR пробел нужен, а что такое bool?
| ], | ||
| $request->validate( | ||
| [ | ||
| 'name' => 'required|string', |
Member
There was a problem hiding this comment.
возможно надо добавить ограничение по символам и типа alpha numeric or просто alpha
app/Policies/OwnerPolicy.php
Outdated
| * | ||
| * @return bool | ||
| */ | ||
| public function ownerBool(User $user, Model $model) |
Member
There was a problem hiding this comment.
если имеется в виду что ожидается bool, то надо добавить тип возвращаемого значения и переименовать в isOwner()
| <div class="bg-body-tertiary overflow-hidden px-5 py-3"> | ||
|
|
||
| @php | ||
| $grouped_comments = $comments->sortBy('created_at')->groupBy('child_id'); |
Member
There was a problem hiding this comment.
по psr то только CamelCase в названии переменных
|
|
||
| <div class="small"> | ||
| <h6 class="mb-0 me-4"> | ||
| <a href="{{route('profile',$post->user)}}" class="text-body-secondary text-decoration-none">{{ $post->user->name }}</a> |
Member
There was a problem hiding this comment.
пробела нет, надо видимо включить в ide проверки
| @if ($isMyAccount) | ||
| <li><a class="dropdown-item" href="{{route('post.edit')}}">Редактировать</a></li> | ||
| {{-- | ||
| <li><a class="dropdown-item" href="#">{{route('post.delete')}}</a></li> |
|
|
||
| $reply = new Comment([ | ||
| 'comment' => $request->input('message'), | ||
| 'approved' => true, |
Member
There was a problem hiding this comment.
надо было назвать колонку is_approved
agoalofalife
approved these changes
Nov 13, 2023
SadElephant
force-pushed
the
profile
branch
5 times, most recently
from
5489b9d to
fa5738d
Compare
ReWiG
pushed a commit
to ReWiG/laravel.su
that referenced
this pull request
Jul 16, 2025
статьи и комментарии для профиля
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Нужно сдлать отдельные шаблоны для комментариев в профиле