Apply fixes from StyleCI

[laravelwebdev]

This pull request applies code style fixes from an analysis carried out by StyleCI.

---

For more information, click here.

Summary by CodeRabbit

Release Notes

• New Features

  • Enhanced cetak method to include a required template_id for fetching templates.
  • Introduced replicateAnggaranAndSpesifikasi method in KerangkaAcuan for copying associated records upon creation.
  • Added success message for contract generation in GenerateKontrakMitra.

• Improvements

  • Improved visibility and validation logic for fields in HonorKegiatan.
  • Adjusted import handling in ImportDaftarHonorMitra and ImportMitra for better data integrity.

• Bug Fixes

  • Minor formatting adjustments for consistency across various methods.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request introduces several changes across multiple files, primarily enhancing functionality and improving code clarity. Key modifications include the addition of a required parameter in the cetak method of the Cetak class, updates to method documentation in the Helper class, and changes to method visibility in the RoleController. Furthermore, several model classes have been updated to improve event handling and data management, particularly in relation to HonorKegiatan and NaskahKeluar. Minor formatting adjustments and whitespace corrections have also been made throughout the codebase.

Changes

File Path	Change Summary
app/Helpers/Cetak.php	Updated cetak method to include a new required parameter $template_id. Minor formatting change in the validate method.
app/Helpers/Helper.php	Updated parameter annotations for methods, including getJenisKontrakById, isAkunHonor, and setOptionsKodeArsip. Minor whitespace adjustments throughout the code.
app/Http/Controllers/RoleController.php	Changed visibility of changeRole method from private to public.
app/Models/AnggaranKerangkaAcuan.php	Modified logic in booted method for creating HonorKegiatan instances. Improved checks for existing records and adjusted handling of associated records.
app/Models/DaftarKontrakMitra.php	Added static::saving event listener in booted method to manage NaskahKeluar instances based on DaftarKontrakMitra state.
app/Models/HonorKegiatan.php	Added import statement for KontrakMitra. Refined logic in booted method for handling jenis_honor attribute.
app/Models/KerangkaAcuan.php	Introduced replicateAnggaranAndSpesifikasi method for copying associated records. Updated booted method to call this new method. Minor refactoring in existing methods.
app/Nova/Actions/GenerateKontrakMitra.php	Added return statement to handle method to indicate success.
app/Nova/Actions/ImportDaftarHonorMitra.php	Updated constructor to accept $honor_kegiatan_id. Modified handle method to check length of 'NIP Lama' field.
app/Nova/Actions/ImportKodeArsip.php	Added assignment for group property in handle method.
app/Nova/Actions/ImportMataAnggaran.php	Adjusted logic in handle method to correctly assign satuan from Volume field.
app/Nova/Actions/ImportMitra.php	Updated updated_at field to null for specific records before data import.
app/Nova/DaftarKontrakMitra.php	Modified fields method to retrieve mitra data using Helper::getMitraById.
app/Nova/HonorKegiatan.php	Enhanced conditional visibility and validation for several fields in fields method.
app/Nova/NaskahKeluar.php	Adjusted indentation of closure in fields method for better readability.

Possibly related PRs

• Apply fixes from StyleCI #36: Changes in the Cetak class in app/Helpers/Cetak.php involve formatting adjustments to the cetak method, directly related to modifications in the main PR.
• Apply fixes from StyleCI #43: This PR includes formatting changes in the Cetak class, specifically in the getTemplate and spj methods, relevant to the main PR.
• Apply fixes from StyleCI #75: Modifications in the Cetak class regarding formatting and minor adjustments are related to the changes in the main PR.
• Apply fixes from StyleCI #74: Involves formatting adjustments in the Cetak class, particularly in the getTemplate method, aligning with the main PR changes.

Poem

🐰 In the fields of code we hop,
New parameters make our hearts stop!
With clearer paths and methods bright,
We dance with joy, oh what a sight!
Formatting fixed, our code's a delight,
Hopping through changes, all feels just right! 🌼

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.