Apply fixes from StyleCI

[laravelwebdev]

This pull request applies code style fixes from an analysis carried out by StyleCI.

---

For more information, click here.

Summary by CodeRabbit

Release Notes

• New Features

  • Added new parameters and validation checks in the Cetak class to enhance document generation.
  • Introduced new static methods for redirection after updates and creations in the DaftarPemeliharaan class.

• Improvements

  • Enhanced control flow and error handling in various models and policies.
  • Improved readability and formatting across multiple classes.

• Bug Fixes

  • Adjusted logic in the DaftarPemeliharaanPolicy for creating and updating records based on request context.

• Chores

  • Cleaned up unused imports and improved code formatting for better consistency.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

This pull request introduces various modifications across multiple files, primarily focusing on enhancing the functionality and readability of several classes. Key changes include the addition of parameters in the Cetak class, updates to relationships in the DaftarPemeliharaan class, and improvements in method structures and formatting across various Nova components. The changes also involve adjustments to policies, migrations, and metrics, ensuring better control flow and error handling while maintaining existing functionalities.

Changes

File	Change Summary
app/Helpers/Cetak.php	Updated cetak and getTemplate methods to include a new parameter $template_id. Modified logic to accommodate the new parameter and enhanced validation checks in the validate method.
app/Models/DaftarPemeliharaan.php	Added masterBarangPemeliharaan method establishing a BelongsTo relationship. Updated deleted event handler for better control flow.
app/Models/Dipa.php	Enhanced deletion process in the booted method, refining cache management during deletions.
app/Models/KerangkaAcuan.php	Removed unused model imports and updated updating method to manage associated records without imports.
app/Models/MasterBarangPemeliharaan.php	Adjusted formatting in daftarPemeliharaan method signature and booted method for consistency.
app/Models/Pemeliharaan.php	Minor formatting adjustments in the booted method for improved readability.
app/Models/PersediaanKeluar.php	Minor formatting change in naskahKeluar method signature.
app/Nova/Actions/ImportMasterBarangPemeliharaan.php	Restructured logic in handle method for clarity; no functional changes.
app/Nova/Actions/ImportMataAnggaran.php	Improved readability of foreach loop and variable assignments; no functional changes.
app/Nova/DaftarPemeliharaan.php	Added methods for redirection after updates and creation, and a new query filter for the index view.
app/Nova/DaftarPesertaPerjalanan.php	Updated validation logic in dependsOn method for select fields.
app/Nova/Filters/BulanFilter.php	Adjusted formatting in apply method's return statement for consistency.
app/Nova/KodeNaskah.php	Adjusted closing brace alignment in actions method; added redirectAfterUpdate method.
app/Nova/Lenses/RealisasiAnggaran.php	Minor formatting change in query method's return statement.
app/Nova/Lenses/RekapBarangPersediaan.php	Standardized SQL query formatting in query method for readability.
app/Nova/Lenses/RekapHonorMitra.php	Minor formatting change in query method for consistency.
app/Nova/Lenses/RencanaPenarikanDana.php	Simplified name method return statement.
app/Nova/MasterBarangPemeliharaan.php	Various formatting adjustments for consistency and clarity.
app/Nova/Metrics/RealisasiPerJenisBelanja.php	Minor string formatting change in viewAll method.
app/Nova/Metrics/RencanaPenarikanPerJenisBelanja.php	Removed unused model imports; retained existing logic.
app/Nova/Metrics/SerapanAnggaran.php	Various formatting adjustments for consistency and readability.
app/Nova/PermintaanPersediaan.php	Updated fields method for better configuration of fields and added dependsOn method for dynamic options.
app/Nova/RealisasiAnggaran.php	Removed unused model imports; no changes to functionality.
app/Policies/BarangPersediaanPolicy.php	Removed unnecessary opening brace in viewAny method for clarity.
app/Policies/DaftarPemeliharaanPolicy.php	Updated create and update methods to use Nova::whenServing for context-based permissions.
app/Policies/MasterBarangPemeliharaanPolicy.php	Adjusted formatting in permission checks for consistency.
database/migrations/2024_11_19_163733_create_daftar_peserta_perjalanans_table.php	Minor formatting adjustment to angkutan column declaration in migration.

Possibly related PRs

• Apply fixes from StyleCI #36: This PR modifies the Cetak class in app/Helpers/Cetak.php, which is directly related to the main PR as it also involves changes to the Cetak class, specifically adding a new parameter to the cetak method.
• Apply fixes from StyleCI #81: This PR also updates the Cetak class in app/Helpers/Cetak.php, adding the same new parameter $template_id to the cetak method and modifying the getTemplate method, which aligns with the changes in the main PR.
• Apply fixes from StyleCI #74: This PR includes formatting changes to the Cetak class in app/Helpers/Cetak.php, specifically in the cetak method, which is relevant to the changes made in the main PR regarding method signatures and parameter handling.

🐰 In the land of code where rabbits hop,
Changes abound, they never stop!
New parameters here, and formatting there,
Making things clearer, with utmost care.
With each little tweak, our code shines bright,
Hopping along, everything feels just right! 🌟

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.