Apply fixes from StyleCI

[laravelwebdev]

This pull request applies code style fixes from an analysis carried out by StyleCI.

---

For more information, click here.

Summary by CodeRabbit

Release Notes

• New Features

  • Enhanced DaftarHonorMitra model to better reflect the status of realizations based on target volumes.
  • Introduced a new method in PerjalananDinas for managing travel participants.
  • Improved field dependencies and validation in PembelianPersediaan.

• Bug Fixes

  • Adjusted logic for action visibility in PembelianPersediaan based on resource state.

• Style

  • Minor formatting improvements across various classes for better readability and consistency.

• Documentation

  • Updated comments and method signatures for clarity in several policy classes.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

This pull request encompasses various modifications across multiple files, primarily focusing on formatting improvements for better code readability. Key changes include adjustments to whitespace around operators and method calls, particularly in policy classes and Nova resources. Additionally, some models have seen logic enhancements, such as updates to event listeners and the introduction of new methods for managing relationships. Overall, the changes maintain existing functionalities while refining the code's clarity and consistency.

Changes

File Path	Change Summary
app/Helpers/Helper.php	Adjusted string concatenation in asterikNik method for improved readability.
app/Models/DaftarHonorMitra.php	Updated saving event listener logic in booted method to set status_realisasi based on comparison of volume_realisasi and volume_target.
app/Models/IzinKeluar.php	Removed unused import statements.
app/Models/PerjalananDinas.php	Added daftarPesertaPerjalanan() method for participant management; refined booted() method for handling NaskahKeluar instances and deletion logic.
app/Nova/BarangPersediaan.php	Adjusted spacing around Policy::make() and hideFromIndex calls for readability.
app/Nova/BastMitra.php	Improved spacing in readonly method calls for various fields.
app/Nova/Filters/GenerateNaskah.php	Removed unused import statement for KodeArsip.
app/Nova/Filters/RoFilter.php	Added space before string in options method for improved readability.
app/Nova/IzinKeluar.php	Modified spacing in updateRules and Text::make method calls for consistency.
app/Nova/KontrakMitra.php	Adjusted spacing in readonly method calls for various fields.
app/Nova/Lenses/RealisasiAnggaran.php	Minor formatting changes in name method; added conditional check for date formatting.
app/Nova/Lenses/RekapBarangPersediaan.php	Adjusted spacing in groupBy method call for consistency.
app/Nova/Lenses/RekapHonorMitra.php	Corrected formatting in groupBy clause of query method for uniformity.
app/Nova/Lenses/RencanaPenarikanDana.php	Minor formatting change in query method for consistency.
app/Nova/MataAnggaran.php	Adjusted comment block indentation for searchableColumns method.
app/Nova/Metrics/RealisasiPerJenisBelanja.php	Modified spacing in assignment of $dipaId variable for consistency.
app/Nova/Metrics/RencanaPenarikanPerJenisBelanja.php	Modified spacing in assignment of $dipaId variable for consistency.
app/Nova/PembelianPersediaan.php	Updated fields, actions, and indexQuery methods to enhance validation rules and action visibility based on resource state.
app/Nova/PermintaanPersediaan.php	Adjusted spacing around negation operator in indexQuery method.
app/Nova/User.php	Adjusted whitespace in method chain for Text::make('Username', 'email').
app/Policies/BastMitraPolicy.php	Added space after negation operator in viewAny method.
app/Policies/DaftarSp2dPolicy.php	Added space after negation operator in viewAny and view methods.
app/Policies/HonorKegiatanPolicy.php	Added space after negation operator in viewAny and view methods.
app/Policies/KontrakMitraPolicy.php	Added space after negation operator in viewAny method.
app/Policies/NaskahKeluarPolicy.php	Added space after negation operator in viewAny method.
app/Policies/NaskahMasukPolicy.php	Added space after negation operator in viewAny method.
app/Policies/RewardPegawaiPolicy.php	Added space after negation operator in viewAny method.

Possibly related PRs

• Apply fixes from StyleCI #28: Modifications in the Helper class in app/Helpers/Helper.php involve formatting changes that enhance code readability, similar to the whitespace adjustments made in the main PR.
• Apply fixes from StyleCI #36: Changes in the Helper class in app/Helpers/Helper.php include the removal of unused imports and formatting adjustments, which align with the focus on code clarity in the main PR.
• Apply fixes from StyleCI #67: The Helper class in app/Helpers/Helper.php has formatting changes that improve documentation clarity, echoing the readability improvements in the main PR.
• Apply fixes from StyleCI #71: The Helper class in app/Helpers/Helper.php includes formatting changes that enhance code readability, consistent with the changes made in the main PR.
• Apply fixes from StyleCI #80: The Helper class in app/Helpers/Helper.php has minor formatting changes that improve consistency, aligning with the objectives of the main PR.
• Apply fixes from StyleCI #81: The Cetak class in app/Helpers/Cetak.php has been modified to improve formatting and clarity, similar to the changes in the main PR.
• Apply fixes from StyleCI #82: The Cetak class in app/Helpers/Cetak.php includes formatting adjustments that enhance readability, consistent with the changes made in the main PR.

🐰 In the land where code does dwell,
Whitespace changes ring the bell.
With clarity now, our paths align,
Each method shines, each line divine.
So let us hop and celebrate,
For clean code makes us all feel great! 🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 389718c and 8a61b17.

📒 Files selected for processing (27)

• app/Helpers/Helper.php (2 hunks)
• app/Models/DaftarHonorMitra.php (0 hunks)
• app/Models/IzinKeluar.php (0 hunks)
• app/Models/PerjalananDinas.php (0 hunks)
• app/Nova/BarangPersediaan.php (1 hunks)
• app/Nova/BastMitra.php (2 hunks)
• app/Nova/Filters/GenerateNaskah.php (0 hunks)
• app/Nova/Filters/RoFilter.php (1 hunks)
• app/Nova/IzinKeluar.php (2 hunks)
• app/Nova/KontrakMitra.php (2 hunks)
• app/Nova/Lenses/RealisasiAnggaran.php (2 hunks)
• app/Nova/Lenses/RekapBarangPersediaan.php (1 hunks)
• app/Nova/Lenses/RekapHonorMitra.php (1 hunks)
• app/Nova/Lenses/RencanaPenarikanDana.php (1 hunks)
• app/Nova/MataAnggaran.php (1 hunks)
• app/Nova/Metrics/RealisasiPerJenisBelanja.php (1 hunks)
• app/Nova/Metrics/RencanaPenarikanPerJenisBelanja.php (1 hunks)
• app/Nova/PembelianPersediaan.php (0 hunks)
• app/Nova/PermintaanPersediaan.php (1 hunks)
• app/Nova/User.php (1 hunks)
• app/Policies/BastMitraPolicy.php (1 hunks)
• app/Policies/DaftarSp2dPolicy.php (2 hunks)
• app/Policies/HonorKegiatanPolicy.php (2 hunks)
• app/Policies/KontrakMitraPolicy.php (1 hunks)
• app/Policies/NaskahKeluarPolicy.php (1 hunks)
• app/Policies/NaskahMasukPolicy.php (1 hunks)
• app/Policies/RewardPegawaiPolicy.php (1 hunks)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.