Add pytype linting to CI #651
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CNugteren
reviewed
May 28, 2021
.github/workflows/lint.yml
Outdated
| - name: Install Lint Dependencies | ||
| run: | | ||
| pip install pyflakes==2.3.0 black==20.8b1 --no-cache-dir | ||
| pip install pyflakes==2.3.0 black==20.8b1 pytype --no-cache-dir |
There was a problem hiding this comment.
Wouldn't it be good to pin the version of pytype? Otherwise a new version might suddenly break some unrelated PR (because of a bug or a new feature).
There was a problem hiding this comment.
Yeah, sorry I forgot to commit that change.
How do you feel about moving these to a test_requirements.txt file, so we can keep them up to date with dependabot?
I'm happy to do this in a future PR.
AdamHillier
approved these changes
May 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add PyType linting to CI to verify our type signatures. We currently ignore some errors since TF and our pybind modules do not provide type stubs and might not exists during linting.