Add constant folding for lq.quantize and lq.dequantize
#654
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Tom Bannink <Tombana@users.noreply.github.com>
Tombana
approved these changes
Jun 8, 2021
CNugteren
approved these changes
Jun 8, 2021
There was a problem hiding this comment.
Just a small comment, otherwise I approve. The name of the PR was a bit confusing to me though, I was going through the code to look for the place where you added a folder or moved something from one folder to another, but then it turns out it was about folding instead of folders (as in paths) 😕 😉
lgeiger
changed the title
lq.quantize and lq.dequantizelq.quantize and lq.dequantize
Good point, changed the title. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
This PR adds constant folders for
lq.quantizeandlq.dequantizeops.This PR also includes a few minor changes from our internal fork to bring them inline with each other.
How Has This Been Tested?
Added MLIR Filecheck
Co-Authored-By: Tom Bannink Tombana@users.noreply.github.com