Skip to content

Conversation

@lasley
Copy link
Member

@lasley lasley commented Sep 17, 2016

It provides better globalized session handling in order to allow for database connections in threaded environments.

  • Create and use global models obj to hold instantiated declaratives

@lasley lasley added this to the 1.0 milestone Sep 17, 2016
@lasley lasley force-pushed the bugfix/0.1/duplicate-meta branch 3 times, most recently from a2da6da to 5b75dad Compare September 17, 2016 22:27
@lasley lasley assigned lasley and unassigned tedsalmon Sep 17, 2016
@lasley lasley force-pushed the bugfix/0.1/duplicate-meta branch from 5b75dad to 7bad2e3 Compare September 17, 2016 22:30
@codecov-io
Copy link

codecov-io commented Sep 17, 2016

Current coverage is 98.32% (diff: 95.20%)

Merging #11 into release/0.1 will increase coverage by 0.20%

@@           release/0.1        #11   diff @@
=============================================
  Files              109        109          
  Lines             2344       2329    -15   
  Methods              0          0          
  Messages             0          0          
  Branches            39         39          
=============================================
- Hits              2300       2290    -10   
+ Misses              28         22     -6   
- Partials            16         17     +1   

Powered by Codecov. Last update 6fa70e7...108f91d

@lasley
Copy link
Member Author

lasley commented Sep 17, 2016

Lmao right as I set it to work in progress, I figured it out. Let there be threaded databasery!!

* Create and use global models obj to hold instantiated declaratives
* Create session context manager to guarantee commits and closes
* Remove `_do_queries` in favor of session context manager
@lasley lasley force-pushed the bugfix/0.1/duplicate-meta branch from a61fafa to 108f91d Compare September 20, 2016 00:33
Copy link
Contributor

@tedsalmon tedsalmon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tedsalmon tedsalmon merged commit 2ed0cf9 into release/0.1 Sep 24, 2016
@tedsalmon tedsalmon deleted the bugfix/0.1/duplicate-meta branch September 24, 2016 23:08
@tedsalmon tedsalmon restored the bugfix/0.1/duplicate-meta branch September 24, 2016 23:09
@tedsalmon
Copy link
Contributor

My bad - read your comment and didn't see that you had removed RFR and readded the WIP label

@lasley lasley deleted the bugfix/0.1/duplicate-meta branch September 29, 2016 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants