Skip to content

Commit f28358a

Browse files
committed
[REF] clouder_template_proxy: Move DH to proxy
* Move diffie-hellman method and field from core to proxy template
1 parent cd6980e commit f28358a

File tree

2 files changed

+21
-21
lines changed

2 files changed

+21
-21
lines changed

clouder/models/base.py

Lines changed: 0 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
from datetime import datetime, timedelta
77
import logging
88
import re
9-
import os.path
109

1110
from openerp import models, fields, api
1211

@@ -79,7 +78,6 @@ class ClouderBase(models.Model):
7978
cert_key = fields.Text('Cert Key')
8079
cert_cert = fields.Text('Cert')
8180
cert_renewal_date = fields.Date('Cert renewal date')
82-
dh_param = fields.Text('Diffie-Helman Params')
8381
reset_id = fields.Many2one('clouder.base', 'Reset with this base')
8482
backup_ids = fields.Many2many(
8583
'clouder.container', 'clouder_base_backup_rel',
@@ -899,22 +897,3 @@ def renew_cert_exec(self):
899897
Renew a certificate
900898
"""
901899
return True
902-
903-
@api.multi
904-
def _create_dh_param(self, proxy, length=4096):
905-
""" It creates & returns new Diffie-Helman parameters
906-
907-
Args:
908-
proxy: (clouder.container) Proxy target to execute on
909-
length: (int) Bit length
910-
Returns:
911-
(str) Diffie-helman parameters
912-
"""
913-
self.ensure_one()
914-
dh_dir = '/etc/ssl/dh_param'
915-
dh_path = os.path.join(dh_dir, '%s.pem' % self.fulldomain)
916-
proxy.execute(['mkdir', '-p', dh_dir])
917-
proxy.execute([
918-
'openssl', 'dhparam', '-out', dh_path, str(length),
919-
])
920-
return proxy.execute(['cat', dh_path])

clouder_template_proxy/template.py

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,8 @@ class ClouderBase(models.Model):
3737
_inherit = 'clouder.base'
3838
DELTA_CERT_RENEW = timedelta(days=45)
3939

40+
dh_param = fields.Text('Diffie-Helman Params')
41+
4042
@property
4143
def nginx_configfile(self):
4244
"""
@@ -140,6 +142,25 @@ def renew_cert_exec(self):
140142
})
141143
return res
142144

145+
@api.multi
146+
def _create_dh_param(self, proxy, length=4096):
147+
""" It creates & returns new Diffie-Helman parameters
148+
149+
Args:
150+
proxy: (clouder.container) Proxy target to execute on
151+
length: (int) Bit length
152+
Returns:
153+
(str) Diffie-helman parameters
154+
"""
155+
self.ensure_one()
156+
dh_dir = '/etc/ssl/dh_param'
157+
dh_path = os.path.join(dh_dir, '%s.pem' % self.fulldomain)
158+
proxy.execute(['mkdir', '-p', dh_dir])
159+
proxy.execute([
160+
'openssl', 'dhparam', '-out', dh_path, str(length),
161+
])
162+
return proxy.execute(['cat', dh_path])
163+
143164
@api.multi
144165
def _get_proxy_links(self):
145166
""" It returns the ``clouder.base.links`` for the current base """

0 commit comments

Comments
 (0)