Skip to content

minor fixes for ref #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lassiecoder merged 1 commit into from
Mar 22, 2025
Merged

minor fixes for ref #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion src/components/ui/timeline.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,12 @@ interface TimelineEntry {

export const Timeline = ({ data }: { data: TimelineEntry[] }) => {
const ref = useRef<HTMLDivElement>(null);
// const containerRef = useRef<HTMLDivElement>(null);
// const containerRef = useRef<HTMLDivElement>(
// null!
// ) as React.RefObject<HTMLElement>;
const containerRef = useRef<HTMLDivElement>(null);

const [height, setHeight] = useState(0);
const [isSmallScreen, setIsSmallScreen] = useState(false);

Expand All @@ -37,8 +42,12 @@ export const Timeline = ({ data }: { data: TimelineEntry[] }) => {
}
}, [ref]);

// const { scrollYProgress } = useScroll({
// target: containerRef,
// offset: ["start 10%", "end 50%"]
// });
const { scrollYProgress } = useScroll({
target: containerRef,
target: containerRef as React.RefObject<HTMLElement>, // Ensure compatibility
offset: ["start 10%", "end 50%"]
});

Expand Down
3 changes: 2 additions & 1 deletion src/components/ui/tracing-beam.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,8 @@ export const TracingBeam = ({
children: React.ReactNode;
className?: string;
}) => {
const ref = useRef<HTMLDivElement>(null);
// const ref = useRef<HTMLDivElement>(null);
const ref = useRef<HTMLDivElement>(null!) as React.RefObject<HTMLElement>;
const { scrollYProgress } = useScroll({
target: ref,
offset: ["start start", "end start"]
Expand Down