Add set drbg seed method #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for now, we initialize the aes_drbg with an instance function, and store the drbg as an `Option<DrbgCtx>` in the struct. we create a function `gen_random_bytes` which takes an `Option<DrbgCtx>`. if present, it uses the DRBG to generate randomness. If absent, it uses `getrandom`, which is the lowest level system crate to generate randomness. this is a bit of a compromise, because ideally one would just set a single function which either is system randomness or is the DRBG, once it's been set. since Rust is finnicky about memory management, and having a function which depends on the current state of an object is difficult, we avoid this for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this creates a function which sets the DRBG seed and creates a DrbgCtx object as an optional instance parameter. This can be used to generate DRBG random bytes. The default is to use
getrandomsystem randomness if no seed is set. We add a unit test to check this. We add this function currently as a parameter toparams. It could probably be moved to autilsfunction.It doesn't seem possible to set a default function, but then also set that same variable to be a function which depends on this
DrbgCtxelement since it is an instantiated variable depending on seed. There may be a way, but I don't see it.