-
Notifications
You must be signed in to change notification settings - Fork 109
pass KernelOps into SharedMemoryCache constructor #1531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've left some comments on the PR, but the main issue I have is with
1.) The lack of documentation regarding using KernelOps. E.g., how does someone who is writing a new kernel that uses shared memory know what to do. We need a extensive wiki page describing this.
2.) How KernelOps will be tested in CI without any SYCL target. How can we ensure that KernelOps are developed correctly?
We can discuss in our call.
I've added some documentation here As we discussed on the call, the |
Documentation is exactly what I wanted, thanks @jcosborn. |
|
This design looks good to me given the requirements, thanks @jcosborn. The wiki page is greatly appreciated. I don't "like" the My only request is for the wiki page; I think the links to files + line-numbers should be modified to be permalinks to a specific commit as opposed to just |
|
Thanks for the review. Making the wiki use permalinks is a good idea. Once this is merged I'll update it with permalinks to develop. |
|
I've fixed the CI, and I think everything has been addressed (except for updating the docs after the merge). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Loos good now. Thanks for the work on this @jcosborn.
|
@jcosborn can you merge in the latest version of develop? This will fix the CSCS pipeline which would be good to run before we merge this in. |
|
@jcosborn merge in |
This will allow the SYCL target to allocate shared memory at kernel launch and pass the pointer in through the KernelOps structure.