Enable the execution of sqlx-cli against a read-only database #4106
+14
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manifest
force-pushed
the
sqlx-cli-read-only-database
branch
from
53b753f to
21e13aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does your PR solve an issue?
fixes #4105.
Is this a breaking change?
No. It enables the execution of sqlx-cli against a read-only database without altering its functionality.
Instead of attempting to create a table describing migrations, we just test for any record within it with the simple
SELECT 1 FROM {table_name}and then create a table if necessary. That is implemented inAnyConnectionbecause this is standard SQL and can serve as a general solution for any database supported by sqlx.