Mention in docs that many #[sqlx::test]s can slow down rebuild time#4320
Open
Kobzol wants to merge 1 commit into
Open
Mention in docs that many #[sqlx::test]s can slow down rebuild time#4320Kobzol wants to merge 1 commit into
#[sqlx::test]s can slow down rebuild time#4320Kobzol wants to merge 1 commit into
Conversation
Collaborator
|
It would be fine to implement the solution in #4318 so we can actually offer a fix to the user. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a mention to the docs of
#[sqlx::test]to warn users that having many such tests that embed migrations in the generated source code can lead to severe source code bloat and long compilation times. I described this in #4318.Does your PR solve an issue?
It provides a hint to users that might run into this issue: #4318
Is this a breaking change?
No