Skip to content

Conversation

@kinyoklion
Copy link
Member

@kinyoklion kinyoklion commented Dec 2, 2025

Add support for topological sort for changesets.


Note

Introduce SortChangeset in DataStoreSorter to topologically sort change sets (preserving metadata) and add comprehensive unit tests.

  • Server SDK Internals:
    • Changeset sorting: Add DataStoreSorter.SortChangeset to topologically sort ChangeSet<ItemDescriptor> entries by dependencies and DataKind priority (segments before features), preserving selector, type, and environment ID.
  • Tests:
    • Add unit tests in DataStoreSorterTest covering:
      • Metadata preservation (Type, Selector, EnvironmentId).
      • Ordering of prerequisite flags (Features) and Segments before Features.
      • Empty changeset handling, multiple DataKinds, and deleted items retention.

Written by Cursor Bugbot for commit 5bd3ec0. This will update automatically on new commits. Configure here.

@kinyoklion
Copy link
Member Author

bugbot review

@kinyoklion kinyoklion force-pushed the rlamb/add-changeset-sorting branch from 06c7933 to 1757212 Compare December 2, 2025 23:47
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no bugs!


Base automatically changed from rlamb/sdk-1583/transactional-store-support to main December 3, 2025 17:36
@kinyoklion
Copy link
Member Author

bugbot review

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no bugs!


@kinyoklion kinyoklion marked this pull request as ready for review December 3, 2025 19:18
@kinyoklion kinyoklion requested a review from a team as a code owner December 3, 2025 19:18
@kinyoklion kinyoklion merged commit 12509dd into main Dec 4, 2025
21 of 24 checks passed
@kinyoklion kinyoklion deleted the rlamb/add-changeset-sorting branch December 4, 2025 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants